Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor up py2/py3 switches #80

Closed
erikrose opened this issue Feb 3, 2015 · 1 comment
Closed

Factor up py2/py3 switches #80

erikrose opened this issue Feb 3, 2015 · 1 comment

Comments

@erikrose
Copy link
Owner

erikrose commented Feb 3, 2015

We do things like this in a few places:

if sys.version_info[0] == 3:
    text_type = str
    basestring = str
else:
    text_type = unicode  # noqa

Let's depend on and use six. There's no reason to be afraid of dependencies.

Blocks #72.

@jquast
Copy link
Collaborator

jquast commented Apr 10, 2015

Pull request #89 is still awaiting your merge to close this issue.

@jquast jquast closed this as completed Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants