Refactor RuleVisitor._resolve_refs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving circular references it is necessary to avoid infinite recursion. Previously this was done by tracking unwalked_names and walking_names. Now infinite recursion is prevented by setting expr.members to None while recursively resolving member expressions.
|
Any feedback on this one? |
|
Taking a look at this now before I mess with _resolve_refs to add support for custom rules. |
|
I love how much shorter it is! But do we guarantee hitting every rule? Yep, the gen expr loop around all the rules covers it. Why didn't I think of this? :-) |
| if expr.name: | ||
| unwalked_names.remove(expr.name) | ||
| original_members = getattr(expr, 'members', None) | ||
| if original_members is not None: |
There was a problem hiding this comment.
Note to self: shorten to if original_members.
erikrose
added a commit
that referenced
this pull request
Jul 12, 2014
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving circular references it is necessary to avoid infinite
recursion. Previously this was done by tracking unwalked_names and
walking_names. Now infinite recursion is prevented by setting
expr.members to None while recursively resolving member expressions.