Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra args #122

Closed
wants to merge 4 commits into from
Closed

Extra args #122

wants to merge 4 commits into from

Conversation

nettnikl
Copy link
Contributor

No description provided.

@erikw
Copy link
Owner

erikw commented Oct 20, 2023

Thanks

@ggzica can you confirm that the bug in
#120
doesn’t appear with this PR?

@ggzica
Copy link

ggzica commented Oct 20, 2023

Thanks

@ggzica can you confirm that the bug in #120 doesn’t appear with this PR?

Hey,
Sorry i'm not very good with switching to PRs?
What's the # of the PR?
I tried gh pr checkout 120 but got an error that could not retrieve

@erikw
Copy link
Owner

erikw commented Oct 20, 2023

122 is the PR number, check the URL of this page

@ggzica
Copy link

ggzica commented Oct 20, 2023

oh, had no idea, checking it now!

@ggzica
Copy link

ggzica commented Oct 20, 2023

Same issue, gets backed up then deleted..
image
image

@nettnikl
Copy link
Contributor Author

nettnikl commented Oct 20, 2023

Well, thanks for testing. But tbh, i dont understand how - the array is not empty anymore. Did you put the env you are using on the old ticket? Could you set "set -x" in the beginning of the script to print the commands out, and see what the command looks like that is the troublemaker?

@ggzica
Copy link

ggzica commented Oct 20, 2023

Well, thanks for testing. But tbh, i dont understand how - the array is not empty anymore. Did you put the env you are using on the old ticket? Could you set "set -x" in the beginning of the script to print the commands out, and see what the command looks like that is the troublemaker?

Yes,
Steps i did:

  1. I copied the env files to a different folder
  2. Ran a make uninstall
  3. Checked out the PR 122
  4. Ran a make install-systemd
  5. Copied back env files Copied in Step 1.

set-x of the script

+ set -o errexit
+ set -o pipefail
+ [[ 0 =~ ^1|t|y|true|yes$ ]]
+ trap exit_hook INT TERM
+ assert_envvars RESTIC_BACKUP_PATHS RESTIC_BACKUP_TAG RESTIC_BACKUP_EXCLUDE_FILE RESTIC_BACKUP_EXTRA_ARGS RESTIC_REPOSITORY RESTIC_VERBOSITY_LEVEL RESTIC_RETENTION_HOURS RESTIC_RETENTION_DAYS RESTIC_RETENTION_MONTHS RESTIC_RETENTION_WEEKS RESTIC_RETENTION_YEARS
+ varnames=('RESTIC_BACKUP_PATHS' 'RESTIC_BACKUP_TAG' 'RESTIC_BACKUP_EXCLUDE_FILE' 'RESTIC_BACKUP_EXTRA_ARGS' 'RESTIC_REPOSITORY' 'RESTIC_VERBOSITY_LEVEL' 'RESTIC_RETENTION_HOURS' 'RESTIC_RETENTION_DAYS' 'RESTIC_RETENTION_MONTHS' 'RESTIC_RETENTION_WEEKS' 'RESTIC_RETENTION_YEARS')
+ local varnames
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ for varname in "${varnames[@]}"
+ '[' -z x ']'
+ warn_on_missing_envvars B2_ACCOUNT_ID B2_ACCOUNT_KEY B2_CONNECTIONS RESTIC_PASSWORD_FILE
+ unset_envs=()
+ local unset_envs
+ varnames=('B2_ACCOUNT_ID' 'B2_ACCOUNT_KEY' 'B2_CONNECTIONS' 'RESTIC_PASSWORD_FILE')
+ local varnames
+ for varname in "${varnames[@]}"
+ '[' -z xxxxxxxxxxxxxxxx ']'
+ for varname in "${varnames[@]}"
+ '[' -z xxxxxxxxxxxxxxxx ']'
+ for varname in "${varnames[@]}"
+ '[' -z 10 ']'
+ for varname in "${varnames[@]}"
+ '[' -z /etc/restic/pw.txt ']'
+ '[' 0 -gt 0 ']'
+ IFS=:
+ read -ra backup_paths
+ B2_ARG=
+ '[' -z x ']'
+ B2_ARG=(--option b2.connections="$B2_CONNECTIONS")
+ extra_args=()
+ IFS=
+ read -r -d ''
++ xargs printf '%s\0'
+ extra_args+=("$REPLY")
+ IFS=
+ read -r -d ''
+ extra_args=("${B2_ARG[@]}" "${extra_args[@]}")
+ backup_extra_args=()
+ IFS=
+ read -r -d ''
++ xargs printf '%s\0'
+ backup_extra_args+=("$REPLY")
+ IFS=
+ read -r -d ''
+ PRE_SCRIPT=/etc/restic/pre_backup.sh
+ test -x /etc/restic/pre_backup.sh
+ exclusion_args=(--exclude-file "$RESTIC_BACKUP_EXCLUDE_FILE")
+ for backup_path in "${backup_paths[@]}"
+ '[' -f /home/xxxxxxxxxxxxxxxx/.backup_exclude.txt ']'
+ FS_ARG=
+ test linux-gnu = msys
+ FS_ARG=--one-file-system
+ wait 41853
+ restic unlock --option b2.connections=10 ''

Copy link

PR is stale; will soon close.

@github-actions github-actions bot added the Stale label Apr 21, 2024
@github-actions github-actions bot closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants