Use file templates to improve security, reproducibility #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billwanjohi
commented
Apr 26, 2019
| install -d $(DEST_CONF) -m 700 | ||
| install $(SRCS_CONF) $(DEST_CONF) | ||
| # will create these files locally only if they don't already exist | ||
| install-conf: | etc/restic/b2_env.sh etc/restic/b2_pw.txt |
There was a problem hiding this comment.
the pipe delimiter indicates that the succeeding files are order-only prerequisites, meaning they will only be made if they don't already exist
billwanjohi
commented
Apr 26, 2019
| # will create these files locally only if they don't already exist | ||
| install-conf: | etc/restic/b2_env.sh etc/restic/b2_pw.txt | ||
| install -d $(DEST_CONF) | ||
| install -m 0600 $(SRCS_CONF) $(DEST_CONF) |
There was a problem hiding this comment.
I figured that it's more important to restrict the reading of the files, rather than the listing of the contents of the directory.
billwanjohi
commented
Apr 26, 2019
| @@ -44,4 +51,4 @@ install-exclude: | |||
| # target: install-systemd - Install systemd timer and service files | |||
| install-systemd: | |||
| install -d $(DEST_SYSTEMD) | |||
| install -m 0644 $(SRCS_SYSTEMD) $(DEST_SYSTEMD) | |||
| install $(SRCS_SYSTEMD) $(DEST_SYSTEMD) | |||
There was a problem hiding this comment.
I found this file permission to be redundant, since this is what I get by default on new files placed in this destination.
|
Nice contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By git-ignoring the files that will hold passwords, creating associated template files for them, and then conditionally creating the files with a couple of new make targets, we can help people install their configuration in a reproducible manner without compromising on security. The commits are separated logically, so you can cherry-pick what you see fit.