Fix Gradle/Google Code resolver for Gradle 1.3

[eriwen]

The ResolverFactory seems to have been changed in Gradle 1.3, causing the plugin to break. Need to refactor or remove.

[jeffastorey]

Do you know what in particular is referencing the ResolverFactory?

[eriwen]

@jeffastorey Reference is here: https://github.com/eriwen/gradle-js-plugin/blob/master/src/main/groovy/com/eriwen/gradle/js/JavaScriptExtension.groovy#L6

Hoping @alkemist can provide some insights.

[eriwen]

Update to plugin version 1.3 after Maven Central syncs in a couple hours.

[jeffastorey]

Thanks, will do.

[jeffastorey]

Build seems to be broken after this update...

[eriwen]

@jeffastorey I saw that, but for some reason haven't been able to replicate it. Passes locally with Gradle 1.2/1.3. Ideas welcome.

[jeffastorey]

It failed for me locally (Ubuntu 12.04 64-bit, Oracle Java 7) both with gradlew and gradle. I did some digging and found that the spec that is failing combined files are not combined in the order they were created.

actual: function fn1(){console.log("1")}function fn3(){console.log("3")}function fn2(){console.log("2")};
expected: function fn1(){console.log("1")}function fn2(){console.log("2")}function fn3(){console.log("3")};

Maybe in the test you could set the combinejs source to be a LinkedHashSet of the files so the order is guaranteed?

[louiseliu]

@jeffastorey @eriwen It failed for me too.

Condition not satisfied:

file("build/all-min.js").text == 'function fn1(){console.log("1")}function fn2(){console.log("2")}function fn3(){console.log("3")};'
| | |
| | false
| | 4 differences (95% similarity)
| | function fn1(){console.log("1")}function fn(3)(){console.log("(3)")}function fn(2)(){console.log("(2)")};
| | function fn1(){console.log("1")}function fn(2)(){console.log("(2)")}function fn(3)(){console.log("(3)")};
| function fn1(){console.log("1")}function fn3(){console.log("3")}function fn2(){console.log("2")};
/home/liuguolin/git/gradle/gradle-js-plugin/build/tmp/testWorkspaces/unknown-test-class-10/build/all-min.js

at com.eriwen.gradle.js.JsPluginFunctionalTest.tasks operation(JsPluginFunctionalTest.groovy:122)

[eriwen]

Bah. Getting a different test failure on JSHintTest > "build passes with only valid files". I think I'm going to stop guessing and just download VirtualBox/Ubuntu and make it pass there before spamming everyone with commits that fail the build.

Reopening this for now.

[jeffastorey]

Has there been a resolution on this so we can get the build passing again?