Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional access token input for private repo dep graphs #3

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

brandly
Copy link
Contributor

@brandly brandly commented Jan 9, 2019

hey! i like this project, but i wanted to graph a private repo. i can do that now!

screen shot 2019-01-09 at 2 02 37 pm

you can generate an access token at this URL. maybe it's worth mentioning that somewhere.

everything goes thru https://api.github.com now instead of https://raw.githubusercontent.com. are there any downsides to that?

what version of elm-format are you using? i have elm-format-0.18 0.6.1-alpha installed, and it's indenting things a bit differently.

@erkal
Copy link
Owner

erkal commented Jan 25, 2019

Hi brandly,

Thank you very much for doing this! I will merge it.

everything goes thru https://api.github.com now instead of https://raw.githubusercontent.com. are there any downsides to that?

I think that what you did, is better.

what version of elm-format are you using? i have elm-format-0.18 0.6.1-alpha installed, and it's indenting things a bit differently.

I am using elm-format 0.8.1

By the way, this is the first pull request of my life. ❤️

@erkal erkal merged commit 074cb45 into erkal:master Jan 25, 2019
@brandly
Copy link
Contributor Author

brandly commented Jan 25, 2019

thanks for merging!

just wanted to mention that the response from https://api.github.com returns more than just the raw source code. you might be interested in taking a look and potentially incorporating that data into the app. i don't have any concrete suggestions, but i thought i should let you know!

I am using elm-format 0.8.1

i actually just upgraded to that version the other day for another project!

By the way, this is the first pull request of my life. ❤️

i'm honored 😄

thanks for taking the time to merge this in! this app is great.

@brandly brandly deleted the patch-1 branch January 25, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants