Reorder switch-cases in publishUpdates

JS is unlikely to have jump tables so we should try to bail out early for update types that happens more often(such as update, dispose)
erlage · Aug 3, 2022 · 1322ba6 · 1322ba6
1 parent 0b71787
commit 1322ba6
Showing 1 changed file with 32 additions and 32 deletions.
diff --git a/packages/rad/lib/src/core/renderer/renderer.dart b/packages/rad/lib/src/core/renderer/renderer.dart
@@ -345,13 +345,35 @@ class Renderer with ServicesResolver {
   }) {
     for (final updateObject in updates) {
       switch (updateObject.widgetUpdateType) {
-        case WidgetUpdateType.dispose:
-          updateObject as WidgetUpdateObjectActionDispose;
+        case WidgetUpdateType.addAllWithoutClean:
+          updateObject as WidgetUpdateObjectActionAddAllWithoutClean;
 
-          disposeWidget(
+          render(
+            mountAtIndex: null,
+            widgets: updateObject.widgets,
+            parentRenderElement: parentRenderElement,
+            flagCleanParentContents: false,
+            jobQueue: jobQueue,
+          );
+
+          break;
+
+        case WidgetUpdateType.update:
+          processWidgetUpdateObjectActionUpdate(
+            jobQueue: jobQueue,
+            updateType: updateType,
+            flagAddIfNotFound: flagAddIfNotFound,
+            updateObject: updateObject as WidgetUpdateObjectActionUpdate,
+          );
+
+          break;
+
+        case WidgetUpdateType.cleanParent:
+          updateObject as WidgetUpdateObjectActionCleanParent;
+
+          cleanRenderElement(
+            renderElement: parentRenderElement,
             jobQueue: jobQueue,
-            flagPreserveTarget: false,
-            renderElement: updateObject.existingElement,
           );
 
           break;
@@ -371,16 +393,6 @@ class Renderer with ServicesResolver {
 
           break;
 
-        case WidgetUpdateType.cleanParent:
-          updateObject as WidgetUpdateObjectActionCleanParent;
-
-          cleanRenderElement(
-            renderElement: parentRenderElement,
-            jobQueue: jobQueue,
-          );
-
-          break;
-
         case WidgetUpdateType.add:
           updateObject as WidgetUpdateObjectActionAdd;
 
@@ -403,25 +415,13 @@ class Renderer with ServicesResolver {
 
           break;
 
-        case WidgetUpdateType.addAllWithoutClean:
-          updateObject as WidgetUpdateObjectActionAddAllWithoutClean;
-
-          render(
-            mountAtIndex: null,
-            widgets: updateObject.widgets,
-            parentRenderElement: parentRenderElement,
-            flagCleanParentContents: false,
-            jobQueue: jobQueue,
-          );
-
-          break;
+        case WidgetUpdateType.dispose:
+          updateObject as WidgetUpdateObjectActionDispose;
 
-        case WidgetUpdateType.update:
-          processWidgetUpdateObjectActionUpdate(
+          disposeWidget(
             jobQueue: jobQueue,
-            updateType: updateType,
-            flagAddIfNotFound: flagAddIfNotFound,
-            updateObject: updateObject as WidgetUpdateObjectActionUpdate,
+            flagPreserveTarget: false,
+            renderElement: updateObject.existingElement,
           );
 
           break;