Add optimization: Short circuit dispose(s)

Short-circuit dispose on parts of tree that doesn't contain any un-mount event listeners
erlage · Aug 3, 2022 · a205856 · a205856
1 parent 9d9b323
commit a205856
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 10 deletions.
diff --git a/packages/rad/lib/src/core/common/abstract/render_element.dart b/packages/rad/lib/src/core/common/abstract/render_element.dart
@@ -404,6 +404,11 @@ abstract class RenderElement implements BuildContext {
 
     _eventListeners = listeners;
 
+    if (_eventListeners.containsKey(RenderEventType.afterUnMountEffect) ||
+        _eventListeners.containsKey(RenderEventType.beforeUnMountEffect)) {
+      _announceUnMountListeners();
+    }
+
     _isEventsRegistered = true;
   }
 
@@ -490,6 +495,33 @@ abstract class RenderElement implements BuildContext {
     }
   }
 
+  /*
+  |--------------------------------------------------------------------------
+  | framework reserved | event announce APIs
+  |--------------------------------------------------------------------------
+  */
+
+  /// Whether this part of tree contains any un-mount event listener.
+  ///
+  /// @nodoc
+  @internal
+  @nonVirtual
+  bool get frameworkContainsUnMountListeners => _containsUnMountListeners;
+  var _containsUnMountListeners = false;
+
+  /// @nodoc
+  @nonVirtual
+  void _announceUnMountListeners() {
+    visitAncestorElements((renderElement) {
+      if (renderElement.frameworkContainsUnMountListeners) {
+        return false;
+      }
+
+      renderElement._containsUnMountListeners = true;
+      return true;
+    });
+  }
+
   /*
   |--------------------------------------------------------------------------
   | framework reserved | lifecycle api

diff --git a/packages/rad/lib/src/core/renderer/renderer.dart b/packages/rad/lib/src/core/renderer/renderer.dart
@@ -924,11 +924,13 @@ class Renderer with ServicesResolver {
     if (renderElement.frameworkChildElements.isNotEmpty) {
       var childElements = renderElement.frameworkEjectChildRenderElements();
 
-      for (final renderElement in childElements) {
-        disposeDetachedRenderElement(
-          renderElement: renderElement,
-          jobQueue: jobQueue,
-        );
+      if (renderElement.frameworkContainsUnMountListeners) {
+        for (final renderElement in childElements) {
+          disposeDetachedRenderElement(
+            renderElement: renderElement,
+            jobQueue: jobQueue,
+          );
+        }
       }
     }
 
@@ -965,11 +967,13 @@ class Renderer with ServicesResolver {
     required RenderElement renderElement,
     required JobQueue jobQueue,
   }) {
-    for (final childElement in renderElement.frameworkChildElements) {
-      disposeDetachedRenderElement(
-        renderElement: childElement,
-        jobQueue: jobQueue,
-      );
+    if (renderElement.frameworkContainsUnMountListeners) {
+      for (final childElement in renderElement.frameworkChildElements) {
+        disposeDetachedRenderElement(
+          renderElement: childElement,
+          jobQueue: jobQueue,
+        );
+      }
     }
 
     renderElement.frameworkDispatchRenderEvent(