Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good job. I liked the implementation. But there are often typos. #12

Closed
mezoni opened this issue Jul 25, 2022 · 2 comments
Closed

Good job. I liked the implementation. But there are often typos. #12

mezoni opened this issue Jul 25, 2022 · 2 comments
Assignees
Labels
enhancement Improvements

Comments

@mezoni
Copy link

mezoni commented Jul 25, 2022

Everything works very clearly.
But the typos hurt the eyes. I recently installed (in vscode) an add-on and it shows all the typos.

Eg.

lM4ZFdJi

f82v3JQI

P.S.
I use Code Spell Checker
But this only works in files opened in the editor.

@hamsbrar
Copy link
Member

Hi, thank you for the report!

Just tried cspell, it reported more than 2,000 issues(including false positives).

I'll start working on this soon. In case you/anyone wanna help, thanks in advance!

hamsbrar added a commit that referenced this issue Jul 26, 2022
Makes cSpell more effective and easy to work with by eliminating false positives and limiting the scope of search.
@hamsbrar hamsbrar added enhancement Improvements good first issue Good for newcomers labels Jul 26, 2022
@hamsbrar hamsbrar self-assigned this Jul 29, 2022
@hamsbrar
Copy link
Member

hamsbrar commented Jul 29, 2022

All typos have been fixed.

To make sure this doesn’t happen again, we've added a cSpell action.

Please note, your editor might still warns you about few words(that we've exempted, see cspell.json).

@hamsbrar hamsbrar removed the good first issue Good for newcomers label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

No branches or pull requests

2 participants