Further adapt to OTP 24 + adopt GHA #539
Conversation
|
|
||
| line_from_loc({Line, _Col}) -> Line; | ||
| line_from_loc(Line) -> Line. | ||
| make_varname(Prefix, CallAnno) -> |
There was a problem hiding this comment.
Many more variables should be called Anno instead of Line, within this file, but I didn't want to pollute the update.
|
I'm pushing a |
|
Moving to draft, since I'm going to try and replace Travis CI with GitHub Actions (running here, for testing purposes). |
|
I've removed |
A warning was issue for _App (with OTP from `master`)
paulo-ferraz-oliveira
changed the title
|
After many a experiment with Github Actions and failing tests, I found that I was missing container option |
rebar.config
Outdated
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| {erl_opts, [ | |||
| {lager_extra_sinks, ['__lager_test_sink']}, | |||
| {platform_define, "^(19|20|21|22)", test_statem}, | |||
| {platform_define, "^(19|20|21|22|23|24)", test_statem}, | |||
There was a problem hiding this comment.
Probably not the best approach. Suggestions are welcome.
There was a problem hiding this comment.
Arguably we'd remove 19 and 20 from this list since we only support the last two stable releases.
Possibly we can also just kill this check entirely now.
|
@paulo-ferraz-oliveira beat me to some of these changes. This seems a bit more urgent now that OTP 24 has reached a public RC. @mrallen1 merging this would help team RabbitMQ test on OTP 24 (and indirectly test Lager on it). |
|
@michaelklishin: cool. The main goal was to prepare for OTP 24, but I thought I could fix the tests too, while moving to GitHub Actions, so I did. We'd appreciate a release too, since MANY of our lib.s still depend on |
|
I don't know much about GHA, but as long as it's more reliable than Travis I don't object. The changes look fine. I think we can probably just remove the platform_define entirely at this point. @mrallen1 any thoughts? |
|
@Vagabond, should we get rid of |
|
@paulo-ferraz-oliveira @lukebakken built the appveyor stuff to test lager on Windows Erlang builds (which I guess was something that RabbitMQ needed) but if it's bit rotted and broken, remove it |
|
@Vagabond @paulo-ferraz-oliveira Kill anything prior to OTP 20 with extreme prejudice - it's on the TODO list, just haven't TODONE it... |
|
@mrallen1: Regarding OTP 20, I cleaned pre OTP-21 stuff from the tests, but didn't go after anything else. I'm OK for merge if you are. |
|
If I have time I'll re-visit a Windows build but yeah feel free to nuke it for now. |
No objections from me. I just hope we will have an OTP 24-compatible release in the next couple of weeks so that all Lager users can begin testing on the OTP 24 RC1, even if they build every dependency from source :) |
|
Thank you very much. I know this was a lot of work - really appreciate it. |
paulo-ferraz-oliveira
deleted the
feature/erl_anno_instead_of_guessing
branch
This pull request builds on top of my previous one.
On the one hand, I prefer
erl_anno:line/1to matching on an "opaque" structure, since this eases maintenance.On the other hand, with a more recent version of OTP (from
master), I got new warnings (introduced by new behaviour from erlang/otp#2995), now fixed.Note: this doesn't fundamentally change the way we handle the location, but it meant I was assuming that the format for that might not change, which might not be true (since OTP 24 isn't out yet).