Skip to content

Commit

Permalink
[#22] Remove un-necessary parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
robertoaloi committed Aug 1, 2019
1 parent 1fbd8e9 commit 471b8ef
Showing 1 changed file with 14 additions and 15 deletions.
29 changes: 14 additions & 15 deletions src/erlang_ls_parser.erl
@@ -1,4 +1,3 @@
%% TODO: Rename into erlang_ls_syntax
-module(erlang_ls_parser).

-export([ annotate/1
Expand Down Expand Up @@ -75,58 +74,58 @@ postorder_update(F, Tree) ->
end).

-spec get_range(syntax_tree(), pos(), {atom(), any()}) -> range().
get_range(_Tree, {Line, Column}, {application, {M, F, _A}}) ->
get_range({Line, Column}, {application, {M, F, _A}}) ->
CFrom = Column - length(atom_to_list(M)),
From = {Line, CFrom},
CTo = Column + length(atom_to_list(F)),
To = {Line, CTo},
#{ from => From, to => To };
get_range(_Tree, {Line, Column}, {application, {F, _A}}) ->
get_range({Line, Column}, {application, {F, _A}}) ->
From = {Line, Column},
To = {Line, Column + length(atom_to_list(F))},
#{ from => From, to => To };
get_range(_Tree, {Line, Column}, {behaviour, Behaviour}) ->
get_range({Line, Column}, {behaviour, Behaviour}) ->
From = {Line, Column - 1},
To = {Line, Column + length("behaviour") + length(atom_to_list(Behaviour))},
#{ from => From, to => To };
get_range(_Tree, {_Line, _Column}, {exports_entry, {_F, _A}}) ->
get_range({_Line, _Column}, {exports_entry, {_F, _A}}) ->
%% TODO: The location information for the arity qualifiers are lost during
%% parsing in `epp_dodger`. This requires fixing.
#{ from => {0, 0}, to => {0, 0} };
get_range(_Tree, {Line, Column}, {function, {F, _A}}) ->
get_range({Line, Column}, {function, {F, _A}}) ->
From = {Line - 1, Column - 1},
To = {Line - 1, Column + length(atom_to_list(F)) - 1},
#{ from => From, to => To };
get_range(_Tree, {Line, _Column}, {define, _Define}) ->
get_range({Line, _Column}, {define, _Define}) ->
From = {Line - 1, 0},
To = From,
#{ from => From, to => To };
get_range(_Tree, {Line, Column}, {include, Include}) ->
get_range({Line, Column}, {include, Include}) ->
From = {Line, Column - 1},
To = {Line, Column + length("include") + length(Include)},
#{ from => From, to => To };
get_range(_Tree, {Line, Column}, {include_lib, Include}) ->
get_range({Line, Column}, {include_lib, Include}) ->
From = {Line, Column - 1},
To = {Line, Column + length("include_lib") + length(Include)},
#{ from => From, to => To };
get_range(_Tree, {Line, Column}, {macro, Macro}) ->
get_range({Line, Column}, {macro, Macro}) ->
From = {Line, Column},
To = {Line, Column + length(atom_to_list(Macro))},
#{ from => From, to => To };
get_range(_Tree, {Line, Column}, {module, _}) ->
get_range({Line, Column}, {module, _}) ->
From = {Line - 1, Column - 1},
To = From,
#{ from => From, to => To };
get_range(_Tree, {Line, Column}, {record_expr, Record}) ->
get_range({Line, Column}, {record_expr, Record}) ->
From = {Line, Column - 1},
To = {Line, Column + length(Record) - 1},
#{ from => From, to => To };
%% TODO: Distinguish between usage poi and definition poi
get_range(_Tree, {Line, _Column}, {record, _Record}) ->
get_range({Line, _Column}, {record, _Record}) ->
From = {Line - 1, 0},
To = From,
#{ from => From, to => To };
get_range(_Tree, {_Line, _Column}, {spec, _Spec}) ->
get_range({_Line, _Column}, {spec, _Spec}) ->
%% TODO: The location information for the arity qualifiers are lost during
%% parsing in `epp_dodger`. This requires fixing.
#{ from => {0, 0}, to => {0, 0} }.
Expand Down Expand Up @@ -251,7 +250,7 @@ analyze(_Tree, _) ->
-spec poi(syntax_tree(), any()) -> poi().
poi(Tree, Info) ->
Pos = erl_syntax:get_pos(Tree),
Range = get_range(Tree, Pos, Info),
Range = get_range(Pos, Info),
#{ type => poi
, info => Info
, range => Range
Expand Down

0 comments on commit 471b8ef

Please sign in to comment.