Improve plugins handling and implement attempted package builds #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the registry used in builds of rebar3 packages in nixpkgs is the same as the one used to create hex-packages.nix files.
gleber
changed the title
hex2nix now reads 'plugins' field from rebar.config and adds it to resulting nix expression. 'build-rebar3.nix' implements propagation of build plugins through dependency tree.
gleber
force-pushed
the
improve-plugins-handling
branch
from
86fc83f
to
34b070a
Compare
If -b switch is provided, hex2nix will run
nix-build $NIX_PATH/nixpkgs -A erlangPackages.<package_version>
for each imported package. Packages which fail to build (for which
nix-build exists with non-zero status) are excluded from
'hex-packages.nix'. Please note that this is an iterative process, which
amends the same file over and over again.
gleber
force-pushed
the
improve-plugins-handling
branch
from
34b070a
to
f47cfd8
Compare
|
@ericbmerritt All fixes done. Please take a look. |
ericbmerritt
added a commit
that referenced
this pull request
Jan 17, 2016
Improve plugins handling and implement attempted package builds
This was referenced Jan 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in description of individual commits. This goes together with changes in erlang-nix/rebar3-nix-bootstrap#2 and nixpkgs changes which will follow.