inets httpd: dir listing href %2F

[gertcuykens]

Describe the bug
All index href attributes have '%2F'...

To Reproduce

inets:start()
{ok, Pid} = inets:start(httpd, [{port, 8080},
                                {server_name,"httpd_server"},
                                {server_root,"/Users/gert/erlang/pgsql"},
                                {document_root,"/Users/gert/erlang/pgsql/doc"},
                                {bind_address, "localhost"}]).

Expected behavior
No %2F in href attribute

Affected versions
Erlang/OTP 23 [erts-11.1.8]

Additional context
OSX

[KennethL]

Can you please elaborate more exactly what you think is wrong?
Is it the output from http://localhost:8080/%2Findex.html?

[gertcuykens]

Thanks for looking into it.

All the url's are wrongly escaped. When you inspect the href attributes should have been / instead of %2F

Also not sure if dumping it in a pre tag is optimal as you can see the layout is not aligned. I believe this was done as a quick temporary solution until somebody has time to create a proper index page generator?

The use of hardcoded image icon url's probably not the best way to go? Maybe remove or replace with unicode characters?

[liangdefeng]

As to the %2F, I met the same issue and below is my temporary solution to it for reference.

In the mod_dir.erl codes, apply the changes which has the following pattern.

change before
get_href(RequestURI ++ "/" ++ InitEntry ++ "/")

change after
get_href(RequestURI) ++ "/" ++ get_href(InitEntry) ++ "/"

[u3s]

Thanks for sharing the suggestion.
Fix will be delivered after the release happens - I have the selected the same way of solving the issue.

[u3s]

Href fix pushed. For alignment and icon problem I will create new improvement issue soon - we would like to postpone it and see if we can get some community contribution in that area.