io_lib:format/3 with chars_limit crashes on certain data

[aartamonau]

Describe the bug
On certain data io_lib:format() crashes when chars_limit is used with a badarg error.

To Reproduce
Run the following snippet. The link to bucket_conf.txt: https://pastebin.com/dl/NYMGCzWU.

1> {ok, [Name, Conf]} = file:consult("bucket_conf.txt"), io_lib:format("Rebalancing bucket ~p with config ~p", [Name, Conf], [{chars_limit, 50000}]).
** exception error: bad argument
     in function  io_lib:format/2
        called as io_lib:format("Rebalancing bucket ~p with config ~p",
                                ["fW7UdP9XFESEaeyN9jyZh-P95aEjty7iOj4IOQSKlHTT0RORo4%og42zG37TitH7%-NP_51-34-501000",
                                 [{auth_type,sasl},
                                  {num_replicas,2},
                                  {replica_index,true},
                                  {ram_quota,2097152000},
                                  {durability_min_level,none},
                                  {frag_percent,50},
                                  {pitr_enabled,false},
                                  {pitr_granularity,600},
                                  {pitr_max_history_age,86400},
                                  {autocompaction,false},
                                  {purge_interval,undefined},
                                  {flush_enabled,false},
                                  {num_threads,3},
                                  {eviction_policy,full_eviction},
                                  {conflict_resolution_type,seqno},
                                  {storage_mode,magma},
                                  {max_ttl,0},
                                  {compression_mode,active},
                                  {type,membase},
                                  {num_vbuckets,1024},
                                  {replication_topology,star},
                                  {repl_type,dcp},
                                  {servers,[...]},
                                  {map_opts_hash,...},
                                  {...}|...]])

Calling io_lib_format:fwrite/3 directly produces the following crash:

2> io_lib_format:fwrite("Rebalancing bucket ~p with config ~p", [Name, Conf], [{chars_limit, 50000}]).
** exception error: no function clause matching io_lib_pretty:pp_tag_tuple({dots,3,3,#Fun<io_lib_pretty.9.27497820>},
                                                                           117,80,49889,1,
                                                                           [32,32,
                                                                            [32,
                                                                             [[[32,"   ",32,32,32],32,"   ",32,32,32],
                                                                              [32,"   ",32,32,32],
                                                                              32,"   ",32,32,32],
                                                                             [[32,"   ",32,32,32],32,"   ",32,32,32],
                                                                             [32,"   ",32,32,32],
                                                                             32,"   ",32,32,32],
                                                                            32,
                                                                            [[[32,"   ",32,32,32],32,"   ",32,32,32],
                                                                             [32,"   ",32,32,32],
                                                                             32,"   ",32,32,32],
                                                                            [[32,"   ",32,32,32],32,"   ",32,32,32],
                                                                            [32,"   ",32,32,32],
                                                                            32,"   ",32,32,32],
                                                                           1,1) (io_lib_pretty.erl, line 188)
     in function  io_lib_pretty:pp/8 (io_lib_pretty.erl, line 173)
     in call from io_lib_pretty:pp_element/8 (io_lib_pretty.erl, line 341)
     in call from io_lib_pretty:pp_tail/10 (io_lib_pretty.erl, line 323)
     in call from io_lib_pretty:pp_tail/10 (io_lib_pretty.erl, line 325)
     in call from io_lib_pretty:pp_list/9 (io_lib_pretty.erl, line 310)
     in call from io_lib_pretty:pp/8 (io_lib_pretty.erl, line 171)
     in call from io_lib_format:build_limited/5 (io_lib_format.erl, line 282)

Expected behavior
The snippet should not crash.

Affected versions
Reproducible on OTP-22 and OTP-24.

[hareen-kancharla]

Hi, will this be merged into OTP-22 too?

[uabboli]

Thanks for the bug report.

A fix has been merged to maint and master, and patches have been created for 23 and 24 (OTP-23.3.4.5, OTP-24.0.4). There will be a patch for 22.