inets example rootserver not starting

[tonywallace64]

Rootserver examples in inets do not start

To Reproduce
tony@resurrection:~/bin/otp_src_24.0/lib/inets/examples/server_root$ erl
Erlang/OTP 24 [erts-12.0] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]

running .erlang in home directory
.erlang completed
Dependencies: []
LibDir /usr/local/lib/erlang/lib
Eshell V12.0 (abort with ^G)
1> inets:start().
ok
2> inets:start(httpd,[{file,"conf/8080.conf"}]).
{error,{missing_property,server_name}}
3>

Expected behavior
I expected the file option to cause the apache style configuration file 8080.conf to load and start the webserver, which then would have been available via web browser.

Affected versions
Version 24.0, other versions not tried

Additional context
Stepping through the code, there is no attempt to convert the apache style configuation file to a property list. Instead httpd_sup tries to validate the supplied property list and finds it lacking. It looks like support for apache style configuration has been dropped without changing the examples. The {file,Path} option is documented but not working when called in this way, and if the example should be started with some other procedure, that is not clear from a readme or other documentation.

[IngelaAndin]

It seems we missed removing one reference to Apache-like file in the httpd man page. But if you look a little more at the same man page it will say "Note support for legacy configuration file with Apache syntax is dropped in OTP-23." We will remove the last reference in an upcoming release.

[tonywallace64]

Thank you for the reply. The examples in the examples directory of inets are out of date too. I will update them to the correct syntax for my own purposes. Would you like a copy when I have finished? Tony

…

On Fri, 2021-10-08 at 06:35 -0700, Ingela Andin wrote: It seems we missed removing one reference to Apache-like file in the httpd man page. But if you look a little more at the same man page it will say "Note support for legacy configuration file with Apache syntax is dropped in OTP-23." We will remove the last reference in an upcoming release. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[IngelaAndin]

Please make a PR. Outdated examples I agree are confusing.

[tonywallace64]

Please find attached revised examples from inet/examples/server_root.How do I run them?

…

On Fri, 2021-10-08 at 08:24 -0700, Ingela Andin wrote: Please make a PR. Outdated examples I agree are confusing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[IngelaAndin]

It seems like the mail interface is stripping your attachment. Could you please make a PR (pull request) instead!

[IngelaAndin]

@tonywallace64 did you see my last comment?

[tonywallace64]

Thank you. My internet has been down for over a week after a lightning strike. Will do pull request shortly. Tony

…

On Tue, 2021-10-26 at 01:26 -0700, Ingela Andin wrote: @tonywallace64 did you see my last comment? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[IngelaAndin]

@tonywallace64 ping

[u3s]

was there a pull request created for examples update and somehow I missed it?
@tonywallace64 - can you try re-attaching the diff if creating a PR is a problem ?

[IngelaAndin]

No, the PR was never created!

[u3s]

manual update merged in #5974 . for examples, I still hope for receiving contribution ... :-)

[IngelaAndin]

Closed by #7079