Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeinclude in efficiency guide does not work #5662

Closed
garazdawi opened this issue Jan 28, 2022 · 0 comments · Fixed by #5666
Closed

codeinclude in efficiency guide does not work #5662

garazdawi opened this issue Jan 28, 2022 · 0 comments · Fixed by #5666
Assignees
@garazdawi
Labels
bug Issue is reported as a bug team:VM Assigned to OTP team VM

Comments

@garazdawi
Copy link
Contributor

Describe the bug

https://www.erlang.org/doc/efficiency_guide/commoncaveats.html#accidental-copying-and-loss-of-sharing

The <codeinclude>'s are not included for some reason.
@garazdawi garazdawi added the bug Issue is reported as a bug label Jan 28, 2022
@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Jan 31, 2022
@garazdawi garazdawi self-assigned this Jan 31, 2022
garazdawi added a commit to garazdawi/otp that referenced this issue Jan 31, 2022
@garazdawi
erl_docgen: Fix codeinclude
d1bd3f2 
The regexp for finding <codeinclude> did not take into
consideration that elements in xml do not need to have
a closing tag. We shouldn't really try parsing xml with
regexp, but we try to make the best of the situtation.

This commit also removed codeinclude from the dtd so that
atlteast in the future if any other codeinclude falls through
the regexp matching the xmllint will catch it.

Closes erlang#5662
@garazdawi garazdawi mentioned this issue Jan 31, 2022
Merged
@garazdawi garazdawi linked a pull request Jan 31, 2022 that will close this issue
erl_docgen: Fix codeinclude #5666
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garazdawi garazdawi

Labels
bug Issue is reported as a bug team:VM Assigned to OTP team VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

erl_docgen: Fix codeinclude garazdawi/otp
2 participants
@garazdawi @rickard-green