Crypto Configure Fails When Using --with-ssl Path on Windows

[andrewcln]

Describe the bug

When building on Windows, and using a custom SSL static library path, the logic in configure.ac does not set the lib_bits variable. This causes configure to look for libraries of the form libcryptoMD rather than libcrypto<bitness>MD.

To Reproduce

In lib/crypto run ./configure --with_ssl="/cygdrive/c/your-static-ssl-lib-build" --disable-dynamic-ssl-lib

Expected behavior

I believe the code should search in the supplied path using the relevant <bitness> token in the library names.

Affected versions
Seen in lib/crypto/configure.in in OTP 24.3.4 but is also in OTP 25 lib/crypto/configure.ac

Additional context

The configure.in/ac script sets lib_bits if with_ssl=yes, as well as standard Windows SSL search paths. This logic could be repeated in the case clause that covers when with_ssl is a path as show in the OTP 24.3.4 diff below (configure.ac in OTP 25 is similar):

--- otp-24.3.4/lib/crypto/configure.in          2022-05-02 11:26:51.000000000 +0100
+++ otp-24.3.4/lib/crypto/configure.in.new      2022-05-26 14:37:12.886100205 +0100
@@ -563,6 +563,12 @@
     else
        AC_MSG_ERROR([no OpenSSL header found in $with_ssl_incl])
     fi
+    if test "$host_os" = "win32" ; then
+        lib_bits=32
+        if test "x$ac_cv_sizeof_void_p" = "x8"; then
+            lib_bits=64
+        fi
+    fi
     SSL_INCDIR="$with_ssl_incl"
     AC_MSG_CHECKING([for OpenSSL in $with_ssl])
     ERL_CRYPTO_CHECK_LIB(["$with_ssl_incl"], [""], ["$with_ssl"])

[sverker]

@andrewcln Thanks for the report and proposed solution. Could you test #6056 and see that also solves your problem.

[andrewcln]

Yes, that works well, thanks.

[IngelaAndin]

#6056 Merged