Shell process terminated unexpectedly when typing tab to get parameter suggestions

[yushli]

Describe the bug

1. Use rebar3 release to build a release with some dependencies, like cowboy or thoas.
2. Run ./_build/default/rel/some_app/bin/some_app console
3. type thoas:encode(
4. type tab to get suggestions
5. Shell terminated with the following messages:
   *** ERROR: Shell process terminated! ***
   =ERROR REPORT==== 11-Jun-2023::23:42:23.102598 ===
   Error in process <0.764.0> on node 'some_app@127.0.0.1' with exit value:
   {function_clause,
   [{filename,join,
   [{error,bad_name},"ebin"],
   [{file,"filename.erl"},{line,454}]},
   {filename,join,1,[{file,"filename.erl"},{line,441}]},
   {code,get_doc,2,[{file,"code.erl"},{line,919}]},
   {edlin_type_suggestion,lookup_type,4,
   [{file,"edlin_type_suggestion.erl"},{line,223}]},
   {edlin_type_suggestion,type_traverser,5,
   [{file,"edlin_type_suggestion.erl"},{line,195}]},
   {edlin_type_suggestion,type_traverser,5,
   [{file,"edlin_type_suggestion.erl"},{line,142}]},
   {edlin_type_suggestion,'-type_traverser/5-lc$^1/1-2-',5,
   [{file,"edlin_type_suggestion.erl"},{line,65}]},
   {edlin_type_suggestion,type_traverser,5,
   [{file,"edlin_type_suggestion.erl"},{line,65}]}]}

Eshell V14.0.1 (press Ctrl+G to abort, type help(). for help)

NOTE:

1. It needs to type "(" before typing tab to reproduce the crash.
2. It doesn't happen when started using rebar3 shell. Type tab in this case successfully gets the suggestions.

To Reproduce
Please follow the above steps to reproduce.
Expected behavior
Type tab should get the suggestions and should not terminate the shell.

Affected versions
Latest OTP dev branch

Additional context

[frazze-jobb]

I have not been able to reproduce this.
tab completion gives me this:

efrfred@elx71487vj2:~/expand_crash_app$ _build/prod/rel/expand_crash_app/bin/expand_crash_app console
Exec: /home/efrfred/expand_crash_app/_build/prod/rel/expand_crash_app/erts-14.0.1/bin/erlexec -boot /home/efrfred/expand_crash_app/_build/prod/rel/expand_crash_app/releases/1.0.0/start -mode embedded -boot_var SYSTEM_LIB_DIR /home/efrfred/expand_crash_app/_build/prod/rel/expand_crash_app/lib -config /home/efrfred/expand_crash_app/_build/prod/rel/expand_crash_app/releases/1.0.0/sys.config -args_file /home/efrfred/expand_crash_app/_build/prod/rel/expand_crash_app/releases/1.0.0/vm.args -- console
Root: /home/efrfred/expand_crash_app/_build/prod/rel/expand_crash_app
/home/efrfred/expand_crash_app/_build/prod/rel/expand_crash_app
Erlang/OTP 27 [DEVELOPMENT] [erts-14.0.1] [source-3a354b80a1] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit:ns]

Eshell V14.0.1 (press Ctrl+G to abort, type help(). for help)
1> thoas:encode
functions
encode(              encode_to_iodata(

Adding '(' myself and pressing tabs gives me this:

1> thoas:encode(
typespecs
thoas:encode/1
thoas:encode/2

[yushli]

Looks like you are testing a prod release. I tried and find out that in rebar.config, if relx options set to
{mode, prod} it works as expected. But if the option is set to {mode, dev} it will crash the shell process.

[frazze-jobb]

Okey I can reproduce it, and solution fixes the issue

[yushli]

Thanks for the quick fix. Look forward to seeing it merged.