Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both ssh_sftp:read_file_info/2,3 and ssh_sftp:read_link_info/2,3 return incorrect record file_info #7897

Closed
shapovalovts opened this issue Nov 21, 2023 · 3 comments · Fixed by #8220
Assignees
Labels
bug Issue is reported as a bug Planned Focus issue added in sprint planning priority:medium team:PS Assigned to OTP team PS

Comments

@shapovalovts
Copy link

Describe the bug
ssh_sftp:read_file_info/2,3 and ssh_sftp:read_link_info/2,3 return record file_info with uid and gid string values, while they must be integers.

To Reproduce
Read any file via one of those functions.

Expected behavior
ssh_sftp:read_file_info/2,3 and ssh_sftp:read_link_info/2,3 return the record in the same format as functions with the same names from file module.

Affected versions
Reproduced on 24.2 and 26.1.2, but in the past was reproduced on older OTP versions as well.

Additional context
The incorrect record can't be used as is, because functions like ssh_stfp:write_file_info raise exceptions because incorrect type of uid and gid in the record.

@shapovalovts shapovalovts added the bug Issue is reported as a bug label Nov 21, 2023
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Nov 22, 2023
@u3s
Copy link
Contributor

u3s commented Nov 28, 2023

Thanks for report we scheduled work on that. It has to wait for a while due to priorities :-/.

@IngelaAndin IngelaAndin added the stalled waiting for input by the Erlang/OTP team label Dec 12, 2023
@IngelaAndin IngelaAndin added the Planned Focus issue added in sprint planning label Feb 15, 2024
@u3s u3s removed the stalled waiting for input by the Erlang/OTP team label Mar 4, 2024
@u3s
Copy link
Contributor

u3s commented Mar 4, 2024

update:

  • a bug seen when Erlang server and Erlang client is used
  • caused by missing list_to_integer conversion in client decoding process

@u3s
Copy link
Contributor

u3s commented Mar 13, 2024

fix is merged to maint and master branches. planned to be released in upcoming patches for OTP-26, OTP-25 and OTP-24.

@u3s u3s closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is reported as a bug Planned Focus issue added in sprint planning priority:medium team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants