ssh: fix decode uid, gid #8220
Merged
ssh: fix decode uid, gid #8220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
u3s
commented
Mar 4, 2024
•
u3s
commented
- adds missing list_to_integer conversion upon decoding
- fix version typo
- enhanced tests
- closes Both ssh_sftp:read_file_info/2,3 and ssh_sftp:read_link_info/2,3 return incorrect record file_info #7897
- closes ssh_sftp:write_file_info/3,4 returns {error,failure} #7895
CT Test Results 2 files 29 suites 18m 6s ⏱️ Results for commit 1a12aa3. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
u3s
commented
Mar 4, 2024
u3s
force-pushed
the
kuba/ssh/fix_decode_uid_gid/OTP-19013
branch
from
76dea23
to
0cf80a8
Compare
u3s
force-pushed
the
kuba/ssh/fix_decode_uid_gid/OTP-19013
branch
from
0cf80a8
to
a63ae6f
Compare
IngelaAndin
reviewed
Mar 11, 2024
u3s
force-pushed
the
kuba/ssh/fix_decode_uid_gid/OTP-19013
branch
3 times, most recently
from
b1eaef6
to
bfb4329
Compare
IngelaAndin
approved these changes
Mar 12, 2024
u3s
force-pushed
the
kuba/ssh/fix_decode_uid_gid/OTP-19013
branch
from
bfb4329
to
b9ac44c
Compare
- adds missing list_to_integer conversion upon decoding - fix version typo - enhanced tests
u3s
force-pushed
the
kuba/ssh/fix_decode_uid_gid/OTP-19013
branch
from
b9ac44c
to
1a12aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.