-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand on the behavior of supervisors #1233
Conversation
The summary line of the commit message is too long and/or ends with a "." Bad message: Expand on the behavior of supervisors. I am a script, I am not human |
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
Thanks - good point. I think the expression "OTP reasons" is a bit vague and does not add value to the information. Could you please rephrase to just stating the fact - e.g. "The termination reason for the supervisor will be shutdown.". |
@sirihansen what do you think about |
Actually, nevermind. You're correct. Just stating the fact would be consistent with the rest of the docs. I'll update it. |
Sorry for not saying this the first time - but it would probably be more precise to say that this is the exit reason for the supervisor itself. (The children may be either shutdown or killed, depending on the value of the 'shutdown' field in the child specification.) |
fixed :) |
Thanks! Just one more thing - could you please wrap the lines in the body of the commit message to ca 72 characters? This is according to the contribution guidelines. |
Add additional details on the behavior of supervisors when reaching maximum restart intensity, as stated by @rvirding at [Medium](https://goo.gl/XhwpSL)
done :) |
Additional details on the behavior of supervisors when reaching maximum restart intensity, as stated by @rvirding at Medium