Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on the behavior of supervisors #1233

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Expand on the behavior of supervisors #1233

merged 1 commit into from
Nov 17, 2016

Conversation

elbrujohalcon
Copy link
Contributor

Additional details on the behavior of supervisors when reaching maximum restart intensity, as stated by @rvirding at Medium

@OTP-Maintainer
Copy link

The summary line of the commit message is too long and/or ends with a "."
Make sure the whole message follows the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages.

Bad message: Expand on the behavior of supervisors.


I am a script, I am not human


@OTP-Maintainer
Copy link

Patch has passed first testings and has been assigned to be reviewed


I am a script, I am not human


@sirihansen
Copy link
Contributor

Thanks - good point. I think the expression "OTP reasons" is a bit vague and does not add value to the information. Could you please rephrase to just stating the fact - e.g. "The termination reason for the supervisor will be shutdown.".

@elbrujohalcon
Copy link
Contributor Author

elbrujohalcon commented Nov 14, 2016

@sirihansen what do you think about dying for <em>expected</em> reasons.
I would like not to loose the data about why this happens this way.

@elbrujohalcon
Copy link
Contributor Author

Actually, nevermind. You're correct. Just stating the fact would be consistent with the rest of the docs. I'll update it.

@sirihansen
Copy link
Contributor

Sorry for not saying this the first time - but it would probably be more precise to say that this is the exit reason for the supervisor itself. (The children may be either shutdown or killed, depending on the value of the 'shutdown' field in the child specification.)

@elbrujohalcon
Copy link
Contributor Author

fixed :)

@sirihansen
Copy link
Contributor

Thanks! Just one more thing - could you please wrap the lines in the body of the commit message to ca 72 characters? This is according to the contribution guidelines.

Add additional details on the behavior of supervisors when
reaching maximum restart intensity, as stated by @rvirding
at [Medium](https://goo.gl/XhwpSL)
@elbrujohalcon
Copy link
Contributor Author

done :)

@sirihansen sirihansen merged commit 26b0619 into erlang:master Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants