Add restart intensity howto section to design principles doc #1289
Conversation
| apply a fix.</p> | ||
| <p>These choices depend a lot on your problem domain. If you don't | ||
| have real time monitoring and ability to fix problems quickly, for | ||
| example in in an embedded system, you might want to accept at most |
There was a problem hiding this comment.
Please remove one "in" from this line.
| will be more reasonable.</p> | ||
| </item> | ||
| <item> | ||
| <p>If your application has nested supervisors, then the total |
There was a problem hiding this comment.
Is it possible to add a "Do not ..." sentence at the beginning of this bullet? (To make it the same pattern as the two bullets above.) Then probably change the naming of the list from "Common mistakes" to "Advice on how to avoid common mistakes" or similar.
| times, which is probably excessive.</p> | ||
| </item> | ||
| </list></p> | ||
| <p>In general, a supervisor should have a lower intensity limit than |
There was a problem hiding this comment.
I think this paragraph is tightly connected with the last bullet of the above list. Could it be moved into that bullet?
|
How about this version? |
sirihansen
added
the
testing
| (before the top level supervisor gives up and terminates the | ||
| application) will be the product of the intensity values of all | ||
| the supervisors above the failing child process.</p> | ||
| <p>For example, If the top level allows 10 restarts, and the next |
There was a problem hiding this comment.
Should be a lower case 'i' in the 'If'.
|
I have added this to our nightly build now. Please correct the upper case 'I' which I pointed out above, and I'll merge as soon as possible. Thanks for your contribution! |
richcarl
force-pushed
the
intensity-tuning-doc
branch
from
c49a38e
to
1bcacc6
Compare
|
Fixed and squashed commits. |
The question "what values should I use for intensity/period in my supervisor" has been asked by both beginners and experienced people for a couple of decades, and it's always been hard to give a good answer. The Erlang documentation has nothing much helpful to say about this important choice. In this patch, I have tried to summarize how I think about these things nowadays, and make it accessible even for beginners. The OTP Design Principles section on Supervisor Maximum Restart Intensity seemed the best place for it.
Comments welcome.