don't delete release file from releases/<vsn> directory

[tsloughter]

No description provided.

[sirihansen]

Sorry for the late response! I don't see why this shouldn't be ok, but I'm a bit curious as to when it is needed? Do you set the sasl env var releases_dir to releases/<vsn>? I this a common thing to do? If so, why?

Anyway - adding this to our nightly tests now...

[tsloughter]

No, not setting releases_dir to anything. The issue arises from when the tarball is releases/<vsn>/<relname>.tar.gz and so relase_handler is passed <vsn>/<relname> for what to unpack.

[sirihansen]

Ok, so you manually create the releases/<vsn> directory, and place the tarball there before unpacking? I think I see the point :) So the change makes sense, but could you please add a test so it is not accidentally refactored away again?

[tsloughter]

Yes. I can't remember why this is how some of us do it... So I should probably figure out that and will update the comments here.

[sirihansen]

@tsloughter Anything new on this? If not, I'll close it.

[tsloughter]

Not yet. I'll try to get to this this week. If I don't you can close it, does that work?

[sirihansen]

I'm closing this now, due to inactivity. Please re-open if you want to continue later on.