Erl compare ext lists bug (ERL-705) #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison did not consider the list tail and therefore
would consider the following pairs of terms equal:
{<<1,2,3>>, [901,902], 224} and {<<1,2,3>>, [901,902], 228}
{a|b} and {a|c}
rickard-green
added
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erl_compare_ext() eventually calls cmp_exe2() for compound terms, and that function doesn't consider the tail for lists.
This means erl_compare_ext() considers the external representation of these two terms to be equal:
But it gets worse! These terms are also considered equal: