Fix ssl specs to reflect gen_tcp/inet #2235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen_tcp and inet allow using Unix Domain sockets since OTP 19. ssl inherently supports them, too, but the host() type and the specs for peername/1 and sockname/1 do not reflect this, thereby causing dialyzer errors.
IngelaAndin
added
team:PS
|
We have approved this PR, I have cherry-picked your commit to main as it did not rebase cleanly. It will be included in the next planned OTP-22 release (OTP-22.1 most likley) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing support for Unix Domain sockets in
ranch, it was discovered that they work seamlessly withsslas well, but the specs do not reflect this, causing dialyzer errors.