crypto: Fix the build of static crypto nifs #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you please use a makefile function like |
|
ok, sounds like a good idea, I'll try it |
sylane
force-pushed
the
sylane/crypto-fix-static-nifs-build
branch
from
8729a7e
to
877e991
Compare
|
I pushed the code using patsubst |
HansN
added
testing
|
Good catch! Could you please rebase this onto the maint branch since it is a bug fix? |
No, you shouldn't have to. Github had fixed that problem last time I checked. |
sylane
force-pushed
the
sylane/crypto-fix-static-nifs-build
branch
from
877e991
to
a6c2a64
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring of the crypto library seems to have broken the static build of the crypto nifs. This PR fixes the issue.