Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify erl_parse.yrl using operator precedence #2584

Merged
merged 1 commit into from May 18, 2020

Conversation

michalmuskala
Copy link
Contributor

This is one of the changes in the parser done during development of the flexible parser for the formatter. It will probably benefit the mainline parser as well. I'm exploring possibilities of upstreaming more changes.

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Apr 3, 2020
@bjorng bjorng added enhancement testing currently being tested, tag is used by OTP internal CI labels May 15, 2020
@bjorng
Copy link
Contributor

bjorng commented May 15, 2020

Added to our daily builds.

@bjorng bjorng merged commit 5440fdc into erlang:master May 18, 2020
@michalmuskala michalmuskala deleted the erl2-upstream branch May 18, 2020 14:33
@uabboli
Copy link
Contributor

uabboli commented Jan 27, 2021

A little late, but...

It has hitherto been necessary to put parentheses around 'catch' under
certain circumstances. One example is mentioned in the docs,
http://erlang.org/doc/reference_manual/expressions.html#catch-and-throw:

A = (catch 1+2).

With this pull request it seems the parentheses are no longer needed.

Can we remove the paragraph from the docs, or is there some other
example where the parentheses are needed? I've tried to find one, so
far without success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants