-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document compiler options warn_missing_spec and warn_missing_spec_all #2918
Document compiler options warn_missing_spec and warn_missing_spec_all #2918
Conversation
Let me know if those tests are sufficient. Mind you I'm not testing new behavior; I'm just (minimally) making sure no regressions are introduced in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request.
The documentation looks good.
The tests are more complicated than they need to be. We usually put tests for options in the application that implements them. In this case, the spec options are implemented in erl_lint
(in STDLIB) and should be tested in erl_lint_SUITE
.
Yeah. I was mislead in the bug report, but I'll fix that. As for the tests, you prefer I make them simpler? I actually think they're as simple as possible, but I'm willing to change them, if you see it fit. |
I mean simpler in the sense that the scaffolding in |
47bc177
to
ce61a16
Compare
Sure thing. Let me simplify these proper. Thanks for your help. |
@bjorng: I squashed most of the previous stuff (now force-pushed), then simplified the test suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I have some more suggestions for changes. When you have done those changes, please squash to a single commit.
14e6676
to
5e4e67c
Compare
@bjorng, I think I've handled all your requests. I squashed all previous commits. Thanks for your help. |
Thanks! Added to our daily builds. |
Thanks for the pull request! |
As discussed in https://bugs.erlang.org/browse/ERL-1430.