Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the subtag used for maps from 0xB to 0xF #315

Merged
merged 1 commit into from
Mar 28, 2014
Merged

Change the subtag used for maps from 0xB to 0xF #315

merged 1 commit into from
Mar 28, 2014

Commits on Mar 26, 2014

  1. Change the subtag used for maps from 0xB to 0xF 

    The subtag chosen for maps breaks crucial assumptions in other parts of
the system, in particular the native code generation scheme used in the
HiPE compiler. Therefore it is better to use 'the other' unused subtag.

The main change here is the use of 0xF subtag for maps instead of 0xB.
The rest of the differences are changes to and additions of comments.

One more comment from my part.
I noticed that the file contains the following two lines:

The comment of the second line is most certainly a copy and paste error
and should be appropriately fixed by the OTP developers. More importantly,
it would be great if that subtag (0x7) turned out to be unused and could
be used for maps instead of the 0xF one. This might turn out very handy
in the future. I can elaborate on this, if needed.
    @kostis
    kostis committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    32eae45 View commit details
    Browse the repository at this point in the history