Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new option 'raw' in file_info functions #413

Merged
merged 1 commit into from
Nov 26, 2014

Conversation

nox
Copy link
Contributor

@nox nox commented Jun 28, 2014

This option allows the caller not to go through the file server for information about files guaranteed to be local.

This option allows the caller not to go through the file server for information
about files guaranteed to be local.
@OTP-Maintainer
Copy link

Patch has passed first testings and has been assigned to be reviewed


I am a script, I am not human


@proxyles
Copy link
Contributor

proxyles commented Sep 9, 2014

This fails under windows platforms. As we removed it from the builds I do not have a log for you at this time.
If you are unable to test this yourself I can supply you with log prints at a later time.

(found something related)
This log below might or might not be old:
Test case: file_SUITE:file_info_basic_directory/1

  • CT Error Notification 2014-07-15 00:29:24.970 * file_SUITE:test_directory failed on line 1285 Reason: {badmatch,{ok,{file_info,0,directory,read_write, ...}

@nox
Copy link
Contributor Author

nox commented Sep 9, 2014

Weird, will look into it, though I have no Window box. Please supply logs next time.

@proxyles
Copy link
Contributor

proxyles commented Sep 9, 2014

@garazdawi is looking into this.
Looks like its a problem on the windows side of things. So you can let it go, we will probably merge it and then fix the problem.

@garazdawi
Copy link
Contributor

According to the msdn docs, GetFileInformationByHandle can return partial values in the BY_HANDLE_FILE_INFORMATION struct. This seems to be the case for nNumberOfLinks on a number of our test machines.

I've fixed the problem by making sure the struct is initialized to 1 for nNumberOfLinks. See https://github.com/garazdawi/otp/tree/lukas/erts/win32-read_file_info-links for the implementation.

Putting this patch back into nightly builds together with my fix.

@marcusarendt marcusarendt merged commit 8df13a3 into erlang:maint Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants