Fix compile error on ARM and GCC < 4.1.0 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since b29ecbd (OTP-10418, R15B03) Erlang does not compile anymore with old versions of GCC that do not have atomic ops builtins on platforms where there is no native ethread implementation (e.g. ARM): In file included from ../include/internal/gcc/ethread.h:29, from ../include/internal/ethread.h:354, from beam/erl_threads.h:264, from beam/erl_smp.h:27, from beam/sys.h:413, from hipe/hipe_mkliterals.c:29: ../include/internal/gcc/ethr_membar.h:49:4: error: #error "No __sync_val_compare_and_swap" This patch adds a header guard in "gcc/ethread.h", as is present in "libatomic_ops/ethread.h".
|
Patch has passed first testings and has been assigned to be reviewed |
|
We will be running this through some more exhaustive tests and if they pass it will be merged for release in R16B02. Please note however that I will be merging this branch as well, which will mean that you have to explicitly tell configure that you intend to use the fallback atomic operations though --disable-native-ethr-impls or --disable-smp-require-native-atomics. |
|
Ok, thanks! I like the explicit configure switch, it is better than silently disabling native atomic ops. |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Dec 25, 2013
"Since b29ecbd (OTP-10418, R15B03) Erlang does not compile anymore with old versions of GCC that do not have atomic ops builtins on platforms where there is no native ethread implementation (e.g. ARM): (...) Please note however that I will be merging this branch as well, which will mean that you have to explicitly tell configure that you intend to use the fallback atomic operations though --disable-native-ethr-impls or --disable-smp-require-native-atomics." Translated: On NetBSD-5.1 (with gcc-4.1.3) the erlang package didn't compile because of > ../include/internal/gcc/ethr_membar.h:49:4: error: > #error "No __sync_val_compare_and_swap" Adding the abovementioned option --disable-native-ethr-impls make the Erlang runtime system use the original (now fallback) code. This should maybe be an pkg option, but for now this has to do.
jperkin
pushed a commit
to TritonDataCenter/pkgsrc-legacy
that referenced
this pull request
Jan 21, 2014
"Since b29ecbd (OTP-10418, R15B03) Erlang does not compile anymore with old versions of GCC that do not have atomic ops builtins on platforms where there is no native ethread implementation (e.g. ARM): (...) Please note however that I will be merging this branch as well, which will mean that you have to explicitly tell configure that you intend to use the fallback atomic operations though --disable-native-ethr-impls or --disable-smp-require-native-atomics." Translated: On NetBSD-5.1 (with gcc-4.1.3) the erlang package didn't compile because of > ../include/internal/gcc/ethr_membar.h:49:4: error: > #error "No __sync_val_compare_and_swap" Adding the abovementioned option --disable-native-ethr-impls make the Erlang runtime system use the original (now fallback) code. This should maybe be an pkg option, but for now this has to do.
jperkin
pushed a commit
to TritonDataCenter/pkgsrc-legacy
that referenced
this pull request
Mar 14, 2014
"Since b29ecbd (OTP-10418, R15B03) Erlang does not compile anymore with old versions of GCC that do not have atomic ops builtins on platforms where there is no native ethread implementation (e.g. ARM): (...) Please note however that I will be merging this branch as well, which will mean that you have to explicitly tell configure that you intend to use the fallback atomic operations though --disable-native-ethr-impls or --disable-smp-require-native-atomics." Translated: On NetBSD-5.1 (with gcc-4.1.3) the erlang package didn't compile because of > ../include/internal/gcc/ethr_membar.h:49:4: error: > #error "No __sync_val_compare_and_swap" Adding the abovementioned option --disable-native-ethr-impls make the Erlang runtime system use the original (now fallback) code. This should maybe be an pkg option, but for now this has to do.
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 11, 2014
"Since b29ecbd (OTP-10418, R15B03) Erlang does not compile anymore with old versions of GCC that do not have atomic ops builtins on platforms where there is no native ethread implementation (e.g. ARM): (...) Please note however that I will be merging this branch as well, which will mean that you have to explicitly tell configure that you intend to use the fallback atomic operations though --disable-native-ethr-impls or --disable-smp-require-native-atomics." Translated: On NetBSD-5.1 (with gcc-4.1.3) the erlang package didn't compile because of > ../include/internal/gcc/ethr_membar.h:49:4: error: > #error "No __sync_val_compare_and_swap" Adding the abovementioned option --disable-native-ethr-impls make the Erlang runtime system use the original (now fallback) code. This should maybe be an pkg option, but for now this has to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since b29ecbd (OTP-10418, R15B03) Erlang does not compile anymore with
old versions of GCC that do not have atomic ops builtins on platforms
where there is no native ethread implementation (e.g. ARM):
In file included from ../include/internal/gcc/ethread.h:29,
from ../include/internal/ethread.h:354,
from beam/erl_threads.h:264,
from beam/erl_smp.h:27,
from beam/sys.h:413,
from hipe/hipe_mkliterals.c:29:
../include/internal/gcc/ethr_membar.h:49:4: error: #error "No __sync_val_compare_and_swap"
This patch adds a header guard in "gcc/ethread.h", as is present in
"libatomic_ops/ethread.h".