Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typespec in gen.erl #4726

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix typespec in gen.erl #4726

merged 1 commit into from
Apr 19, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

Closes #4725... as per the issue's description and analysis.

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Apr 12, 2021
@rickard-green rickard-green self-assigned this Apr 12, 2021
@paulo-ferraz-oliveira
Copy link
Contributor Author

@rickard-green, I'm still unsure where the ignore comes from, since I didn't go down the rabbit hole.

@rickard-green rickard-green added fix testing currently being tested, tag is used by OTP internal CI labels Apr 13, 2021
@rickard-green
Copy link
Contributor

The init() function of the callback module may return ignore which in turn also will be returned by start*() functions.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Ah, you mean gen_server and family 👍, I get it. There's still some references to gen_fsm there, though. I could clean up in a different pull request.

@rickard-green rickard-green merged commit 771502b into erlang:master Apr 19, 2021
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/gen_erl-start_ret branch July 25, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rickard-green rickard-green

Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start_ret() type definition does not take into account start_monitor
2 participants
@paulo-ferraz-oliveira @rickard-green