Fix miscompilation when module contains multiple named funs #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A module containing two named funs bearing the same name and arity could be miscompiled. Reported-by: Sam Chapin
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
|
The correction itself looks good. The test case, however, does not fail when I revert the correction. I have corrected the test case by adding a line to the eep37_dup/1 function: eep37_dup(Config) when is_list(Config) -> We will test the branch a few days in our daily builds. |
|
Oh, sorry, I was pretty sure it did. Thanks for correcting it yourself. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A module containing two named funs bearing the same name and arity could be miscompiled.
@sfwc