Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist_util_spawn_options in kernel #5069

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

zzydxm
Copy link
Contributor

@zzydxm zzydxm commented Jul 23, 2021

This change allows user to specify spawn options when dist protocol
starts dist_util:handshake_other_started or handshake_we_started
processes.

These processes will be alive until the connections are down. With
thousands of ssl dist connections it spends quite amount of memory,
and it would be great if we can change garbage collection, as well
as other spawn options for dist_util processes.

@RaimoNiskanen RaimoNiskanen added the team:VM Assigned to OTP team VM label Jul 26, 2021
@rickard-green rickard-green self-assigned this Aug 9, 2021
@rickard-green
Copy link
Contributor

I think a better parameter name would be net_ticker_spawn_options or similar, since these are the processes enforcing the value of the net_ticktime kernel configuration parameter.

I'm not sure I think it is a good idea to allow the user to lower the priority. Perhaps it should be forced just like the link option, but as I said I'm not sure.

This change allows user to specify spawn options when dist protocol
starts dist_util:handshake_other_started or handshake_we_started
processes.

These processes will be alive until the connections are down. With
thousands of ssl dist connections it spends quite amount of memory,
and it would be great if we can change garbage collection, as well
as other spawn options for dist_util processes.
@zzydxm
Copy link
Contributor Author

zzydxm commented Aug 16, 2021

Thanks for the comment! I've changed the option name and default option to force priority max.

@rickard-green rickard-green added the testing currently being tested, tag is used by OTP internal CI label Aug 17, 2021
@rickard-green rickard-green merged commit e927a82 into erlang:master Sep 7, 2021
@zzydxm zzydxm deleted the dist-util-spawn-opt branch October 22, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants