Improved inline multiplication in JIT for x86 #5237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves multiplication for small integers inline with overflow checking, along with specialization for when the left or right hand side are immediates.
The original comments related to clobbering
RDX
, I think, are incorrect based on how we're usingimul
in 2-operand form instead of 1-operand form (see reference docs forimul
):As a very non-scientific benchmark: based on some tests involving a pure Erlang version of
MurmurHash3_x86_32
with a 1MB input key, this change alone roughly doubled performance for me (30ms originally down to 15ms).