stdlib: Fix erl_error to print re compile errors #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When re:run and friends fail because the regexp is invalid
it would print in the error message that the regexp was of
an invalid type. Now it will instead print the compilation
error message gotten from running re:compile.
Before:
> re:run("asd",")").
** exception error: bad argument
in function re:run/2
called as re:run("asd",")")
*** argument 2: neither an iodata term nor a compiled regular expression
After:
> re:run("asd",")").
** exception error: bad argument
in function re:run/2
called as re:run("asd",")")
*** argument 2: could not parse regular expression
unmatched parentheses on character 0
garazdawi
added
team:VM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re:run and friends fail because the regexp is invalid it would print in the error message that the regexp was of
an invalid type. Now it will instead print the compilation error message gotten from running re:compile.
Before:
After: