erts: Fix ets memory calculation for read_concurrency #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
added
the
testing
sverker
approved these changes
Dec 9, 2021
Comment on lines
+3082
to
+3084
| %% The memory of ordered_set with write concurrency is | ||
| %% smaller than without write concurrency on systems with | ||
| %% few schedulers. |
There was a problem hiding this comment.
The non-ca implementation pre-allocates memory to use as the traversal stack, so that uses a bit of extra memory for non-ca. As the number of schedulers grow, the base node rw lock in the ca implementation starts using more and more memory, and at 6 schedulers that memory is the same as the size of the pre-allocated traversal stack.
The amount of memory used for reader groups can be very large on systems with many cores, so it needs to be part of the ets table's memory utilization. We use that memory to calculate how many tables can be created when testing.
garazdawi
force-pushed
the
lukas/erts/fix-ets-read_concurrency-memory
branch
from
6780d18
to
a67c456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of memory used for reader groups can be very
large on systems with many cores, so it needs to be part
of the ets table's memory utilization. We use that memory
to calculate how many tables can be created when testing.