Support Ed25519/Ed448 SSH host keys in old format #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansN
added
enhancement
testing
|
Thanks for the PR - indeed a good addition to ssh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use a host OS to generate a key via
ssh-keygenfor elliptic curves ed25519 and ed448, they would be generated in OpenSSH format which is currently supported in OTP.However, if you use another generator, (i.e.
openssl) or create a private key via Erlang functions (i.e.public_key:generate_key({namedCurve, ed25519})), it will format the key with---- BEGIN EC PRIVATE KEY ----which is not currently supported.This PR adds in support for Ed25519/Ed448 SSH host keys in this old format to allow for key generation and storage via Erlang functions.