Fix erl -profile_boot true crash #5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside of this function is used erlang:trace_info(_, call_time) which can return
{call_time, list()} | {call_time, boolean()} | {call_time, undefined}
The issue was in missing clause matching for {call_time, undefined}
|
This is my first trying of contribution for |
We will push any updates to preloaded and the primary bootstrap that are needed. So what you have done is correct. Adding this change to tests, not that I expect that it will break anything but you never know... |
garazdawi
added
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside of
init:collect_mfas/2function is usederlang:trace_info(_, call_time)which can return{call_time, list()}|{call_time, boolean()}|{call_time, undefined}The issue was in missing clause matching for
{call_time, undefined}Related to #5264.