ets: Rename and export some types #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* access() -> table_access() * tab() -> table() * type() -> table_type() * comp_match_spec() -> compiled_match_spec() The exported types have their old variants kept for backward compatibility.
garazdawi
added
team:VM
CT Test Results 5 files 251 suites 2h 1m 31s ⏱️ For more details on these failures, see this check. Results for commit 80d7c33. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/stdlib/fix-ets-types/GH-4915
branch
from
509e353
to
5f6fad9
Compare
Closed
sverker
approved these changes
Jan 26, 2022
|
|
|
I think this is good |
KennethL
approved these changes
Jan 28, 2022
garazdawi
force-pushed
the
lukas/stdlib/fix-ets-types/GH-4915
branch
from
5f6fad9
to
80d7c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename some ets types to clearer name:
The exported types have their old variants kept for backward compatibility.
The types
table_accessandtable_typehave been exported.For consistency, I also renamed all usage of
TabtoTablewithin the ets module itself.