Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-actions: Upload macOS builds to releases #5723

Closed
wants to merge 4 commits into from

Conversation

wojtekmach
Copy link
Contributor

@wojtekmach wojtekmach commented Feb 16, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022

CT Test Results

  1 files  11 suites   1m 37s ⏱️
80 tests 76 ✔️ 4 💤 0
84 runs  80 ✔️ 4 💤 0

Results for commit 98ae87a.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@garazdawi
Copy link
Contributor

I'm not the person the makes the final decision about this, but in my opinion we should not do this. It makes it our responsibility to maintain the images and that is not something that we should do.

I'd be happy to help discuss and implement a way to deliver binary packages for Erlang on various platforms, but I do not think that we should be responsible for maintaining it and thus it should not be part of the Erlang/OTP repository.

@paulo-ferraz-oliveira
Copy link
Contributor

@garazdawi, would we be able to pull it off using only public resources, like GitHub, for example? One other solution could also be to go to the ErlEf and ask for storage. I mean, what @wojtekmach did was already the heavy lifting; maybe adapting it to a different storage wouldn't be too hard? (we would, however, require it to be "linked" to this repo. so that storage would be kept updated). @wojtekmach, let me know if I can help in any way.

@max-au
Copy link
Contributor

max-au commented Feb 17, 2022

@paulo-ferraz-oliveira EEF (Build&Packaging WG) is attempting a prototype of CI/CD based on GitLab (see ci.erlef.org and corresponding discussions on Slack channel). I think there is more sense to host and support all community releases (including MacOS, iOS, ...) using that capacity.

@paulo-ferraz-oliveira
Copy link
Contributor

@max-au, thanks. That might just be a solution. I guess you need to talk to @wojtekmach, then 😄 Are the solutions compatible? ie. is the effort to set up that CI already taking @wojtekmach's solution into account (or would otherwise easily integrate it?).

Having a central place where all is available makes for easier searching of artefacts (something erlef/setup-beam can benefit from).

@garazdawi
Copy link
Contributor

would we be able to pull it off using only public resources, like GitHub, for example?

If all we want to do is to build binary packages for various OSs, then what github provides should be plenty. If we also want to test that the packages actually work, then we probably have to step outside what github provides and into what @max-au is working on.

The main problem IMO is finding someone (person or organization) that is willing to spend the time to work out all the problems that are sure to arise as Erlang/MacOS/openssl/wx versions change. I expect there to be a lot of issues popping up, but maybe I'm over pessimistic.

@max-au
Copy link
Contributor

max-au commented Feb 19, 2022

@paulo-ferraz-oliveira Storage might be an issue if we need to produce too many versions of various packages. But in the end I'd like to have the CI/CD integrated into popular package management systems (e.g. Homebrew, Choco, ...)

@wojtekmach
Copy link
Contributor Author

There doesn't seem to be enough appetite for this so I'm closing this. Happy to re-open anytime, please let me know.

For anyone needing this there's a community-led project https://beammachine.cloud. There's a caveat around transfer costs so a good starting point for anyone wanting to help out is to put a CDN in front. Talk to maintainers if you want to help.

@wojtekmach wojtekmach closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PO Assigned to OTP team PO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERL-1428: OTP binary releases for macOS
5 participants