Add options to binary construction error_info formatting #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 5 files 251 suites 1h 59m 46s ⏱️ For more details on these failures, see this check. Results for commit 5a521ef. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Thanks for your pull request. The test case |
* override_segment_position is used by erl_eval/eval_bits
to override the actual binary segment
* pretty_printer can be used by other BEAM languages to
customize how values in error messages are printed
Prior to this commit, binary construction errors in the
shell reported the following:
1> A = "foo".
"foo"
2> <<A/integer>>.
** exception error: bad argument
in function eval_bits:eval_exp_field1/6 (eval_bits.erl, line 123)
With this commit:
1> A = "foo".
"foo"
2> <<A/integer>>.
** exception error: construction of binary failed
in function eval_bits:eval_exp_field/6 (src/eval_bits.erl, line 143)
*** segment 1 of type 'integer': expected an integer but got: "foo"
3> <<0, A/integer>>.
** exception error: construction of binary failed
in function eval_bits:eval_exp_field/6 (src/eval_bits.erl, line 143)
*** segment 2 of type 'integer': expected an integer but got: "foo"
josevalim
force-pushed
the
jv-bs-fail-opts
branch
from
3d23015
to
5a521ef
Compare
|
@bjorng fixed, ty! |
|
Thanks! Added to our daily builds. |
bjorng
approved these changes
Mar 1, 2022
|
Thanks for your pull request. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new options are:
override_segment_positionis used by erl_eval/eval_bitsto override the actual binary segment
pretty_printercan be used by other BEAM languages tocustomize how values in error messages are printed
Prior to this commit, binary construction errors in the
shell reported the following:
With this commit: