Improve response handling for asynchronous gen and erpc requests #5792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickard-green
added
team:VM
CT Test Results 3 files 137 suites 1h 25m 34s ⏱️ Results for commit cb67a70. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
rickard-green
force-pushed
the
rickard/async-response-improvement/OTP-17784
branch
from
dcc2365
to
18176e9
Compare
rickard-green
added
testing
rickard-green
force-pushed
the
rickard/async-response-improvement/OTP-17784
branch
from
18176e9
to
e9803e1
Compare
rickard-green
added
the
testing
rickard-green
force-pushed
the
rickard/async-response-improvement/OTP-17784
branch
5 times, most recently
from
11b7313
to
9487157
Compare
receive_response/3, wait_response/3, and check_response/3 in 'gen_server', 'gen_statem', and 'gen_event' can now take a collection of request identifiers as argument and handle any responses corresponding a request identifier in the collection.
receive_response/3, wait_response/3, and check_response/3 in 'erpc' can now take a collection of request identifiers as argument and handle any responses corresponding a request identifier in the collection.
rickard-green
force-pushed
the
rickard/async-response-improvement/OTP-17784
branch
from
9487157
to
cb67a70
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
receive_response(),wait_response(), andcheck_response()ingen_server,gen_statem,gen_event, anderpccan now take a collection of request identifiers as argument and handle any responses corresponding to a request identifier in the collection.gen_server-send_request/4,receive_response/3,wait_response/3,check_response/3gen_statem-send_request/4,receive_response/3,wait_response/3,check_response/3gen_event-send_request/5,receive_response/3,wait_response/3,check_response/3erpc-send_request/6,receive_response/3,wait_response/3,check_response/3Edit: API changed 19/3-2022 due to OTP Technical Board decision