Fix space and unicode characters in release/install path #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 9 files 262 suites 3h 19m 58s ⏱️ For more details on these failures, see this check. Results for commit f6eecb0. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/otp/fix-space-unicode-prefix
branch
from
b22ab2f
to
7a7274d
Compare
garazdawi
added
the
testing
garazdawi
force-pushed
the
lukas/otp/fix-space-unicode-prefix
branch
2 times, most recently
from
d14b955
to
f6eecb0
Compare
The change in 4ee5806 broke this test as the install never copied the correct file as the directory did not exist.
garazdawi
force-pushed
the
lukas/otp/fix-space-unicode-prefix
branch
from
f6eecb0
to
dcd495c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes so that make
release,release_docs,installandinstall-docscan work with paths that have space and/or unicode characters in the path. It also expands the gh actions tests to build using space+unicode so that it will continue working in the future.