-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5719 - Adding Stacktrace to thrown #6029
5719 - Adding Stacktrace to thrown #6029
Conversation
CT Test Results 2 files 58 suites 1h 18m 27s ⏱️ Results for commit 8bd699b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
You need to change the test case to reflect the new behavior:
|
Updated ... was going down a rabbit hole of how to exclude the content of the stacktrace |
Changed the validation to not hard coded the the value of the stack trace: https://github.com/erlang/otp/pull/6029/files#diff-539120c7eb2fd386287985533ae198bc22aa46cbaa5e780f61a76b602cbaf8fdR1220 Removes the issue of line numbers changing in the stack trace. Being first commit to erlang/OTP, took some learning. Apologize for any trouble. Let me know if anything else is needed. Thank you |
23eb1ef
to
19b88d0
Compare
- For Common_tests: Added to Match Results for thrown and not hard coded to Content of stacktrace
19b88d0
to
8bd699b
Compare
It is good now, thank you for the PR. |
this commit fixes #5719
New Stacktrace with thrown is:
no change to without Thrown and Normal Error: