erts: Fix large read/writes on macOS #6248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
added
team:VM
CT Test Results 4 files 179 suites 1h 45m 10s ⏱️ For more details on these failures, see this check. Results for commit 1369f39. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/erts/fix-large-read-write-macOS/OTP-18222
branch
from
0cceb1c
to
3994f81
Compare
mikpe
reviewed
Aug 26, 2022
garazdawi
force-pushed
the
lukas/erts/fix-large-read-write-macOS/OTP-18222
branch
3 times, most recently
from
305e514
to
fdd8646
Compare
On macOS there is an (as far as I can tell) undocumented limitation for read and write that the size is not allowed to be greater than 2GB. So if we get an EINVAL from read/write and the size is > 2GB we try again with a smaller size. Closes erlang#6242
When the binary being encoded is was exactly the same size as the maximum iovec segment the number of iovec_len would end up being off by 1 which could lead to a segfault when writing the buffers.
garazdawi
force-pushed
the
lukas/erts/fix-large-read-write-macOS/OTP-18222
branch
from
fdd8646
to
1369f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS there is an (as far as I can tell) undocumented limitation
for read and write that the size is not allowed to be greater than
2GB. So if we get an EINVAL from read/write and the size is > 2GB
we try again with a smaller size.
Closes #6242