ssl: adjust cacertfile option #6287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
u3s
commented
Sep 8, 2022
u3s
commented
- perform conversions before loading cert data from file
- convert relative path to absolute for avoiding collisions
- convert symlink to actual file path
IngelaAndin
reviewed
Sep 8, 2022
IngelaAndin
reviewed
Sep 8, 2022
CT Test Results 2 files 64 suites 47m 45s ⏱️ Results for commit 443696e. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
reviewed
Sep 8, 2022
| @@ -390,12 +390,12 @@ alternative_path_hardlink(Config) when is_list(Config) -> | |||
| alternative_path_symlink() -> | |||
| [{doc,"Test that internal reference table contains expected data for" | |||
| " absolute and symbolic link. " | |||
| "This test verifies handling of same file with an alternative reference."}]. | |||
| %% see alternative_path_hardlink for specification | |||
| "This test verifies handling of same file with an alternative reference." | |||
There was a problem hiding this comment.
Maybe add some explanation of why counters change in the way they do!? See for instance the manual clean-up case.
There was a problem hiding this comment.
I tried to improve the comment.
u3s
force-pushed
the
kuba/ssl/cacertfile_absname_readlink/OTP-18099
branch
from
443696e
to
3573d89
Compare
- perform conversions before loading cert data from file - convert relative path to absolute for avoiding collisions - convert symlink to actual file path
u3s
force-pushed
the
kuba/ssl/cacertfile_absname_readlink/OTP-18099
branch
from
3573d89
to
8c7fa30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.