Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/crypto: autoconf: Add missing ',' in an AC_IF #6596

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

tj90241
Copy link
Contributor

@tj90241 tj90241 commented Dec 26, 2022

This commit fixes an issue wherein old versions of autoconf will misgenerate the configure script due to a missing comma an in AS_IF macro.

Signed-off-by: Tyler J. Stachecki <stachecki.tyler@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Dec 26, 2022

CLA assistant check
All committers have signed the CLA.

@tj90241
Copy link
Contributor Author

tj90241 commented Dec 26, 2022

Please check this closely - I do NOT claim to be an autoconf expert! Nonetheless, this seems to be an unintentional mistake.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

CT Test Results

    2 files    14 suites   6m 42s ⏱️
185 tests 172 ✔️   13 💤 0
465 runs  333 ✔️ 132 💤 0

Results for commit 66c39d7.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Jan 2, 2023
@rickard-green
Copy link
Contributor

@tj90241 Please sign the CLA (above)

@rickard-green rickard-green self-assigned this Jan 2, 2023
@tj90241
Copy link
Contributor Author

tj90241 commented Jan 3, 2023

Sorry about the delay there, had to ensure that I was in the position to do so -- done.

@rickard-green rickard-green changed the base branch from master to maint January 3, 2023 13:55
@rickard-green rickard-green added the testing currently being tested, tag is used by OTP internal CI label Jan 3, 2023
@rickard-green
Copy link
Contributor

Thanks!

@rickard-green rickard-green merged commit f3e2505 into erlang:maint Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants