Update on_load handling during boot #6817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test ResultsNo tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured. Results for commit 73249a8 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Introduce a transient worker that is started by kernel:init and that only calls init:run_on_load_handlers(), which will run all so far postponed (after code load) on_load handlers. The worker exits immediately after that. This on_load worker is run after code_server and standard_error, which should provide enough fundamentals for the on_load handlers themselves. The need for explicitly calling on_load handlers from e.g user_drv and the SSL distribution inet_tls_dist should vanish. Therefore init:run_on_load_handlers/1 should be removed, but to avoid bootstrap problems that can wait to a later commit.
RaimoNiskanen
force-pushed
the
raimo/kernel/boot-on_load
branch
from
4a28031
to
73249a8
Compare
|
I added commits that remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a transient worker that is started by kernel:init and that only calls init:run_on_load_handlers(), which will run all so far postponed (after code load) on_load handlers. The worker exits immediately after that.
This on_load worker is run after code_server and standard_error, which should provide enough fundamentals for the on_load handlers themselves.
The need for explicitly calling on_load handlers from e.g user_drv and the SSL distribution inet_tls_dist should vanish.
Therefore init:run_on_load_handlers/1 should be removed, but to avoid bootstrap problems that can wait to a later commit.