Move instrument.erl to runtime_tools #6829
Conversation
CT Test Results 5 files 152 suites 54m 55s ⏱️ Results for commit 7671649. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Dialyzer is failing but I have no idea how it still finds instrument.erl in tools :D |
I think is a docker / cache problem. I can't replicate the failure locally, FWIW. |
jhogberg
added
testing
|
Thanks for the PR! The doc check fails at the moment, try updating the efficiency guide and ERTS documentation to point at |
instrument.erl can be a useful tool for debugging memory allocation and memory leaks in production systems. For example, eventually we could have a button in Observer that invokes instrument and prints a histogram on demand. For this purpose, however, it must be part of runtime_tools.
josevalim
force-pushed
the
jv-move-instrument
branch
from
2395786
to
7671649
Compare
|
@starbelly thank you. @jhogberg fixed. |
jhogberg
added
the
testing
|
Merged, thanks again for the PR! |
instrument.erl can be a useful tool for debugging
memory allocation and memory leaks in production
systems. For example, eventually we could have a
button in Observer that invokes instrument and
prints a histogram on demand. For this purpose,
however, it must be part of runtime_tools.
Feel free to close this PR if you believe this is the
wrong approach. :)